Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add shell integration setup for fastfetch #1002

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mateuszkozako
Copy link

Type of Change

  • Refactoring

Description

Enhanced RC file detection in fastfetch-setup.sh by implementing a fallback mechanism to search for shell configuration files in the home directory. This improvement helps handle cases where RC files might be named differently or located in non-standard locations within $HOME.

Key changes:

  • Added fallback search for .bashrc and .bash_profile in $HOME for bash
  • Added fallback search for .zshrc in $HOME for zsh
  • Improved error handling for cases when no RC file is found

Testing

  • Tested with bash and zsh shells
  • Verified fallback search works when default RC files are not present
  • Confirmed proper error handling when no RC files are found
  • Tested with different RC file configurations (.bashrc, .bash_profile)

Impact

  • Improved reliability of shell configuration
  • No new dependencies added
  • Maintains backward compatibility
  • Better user experience with more robust RC file detection

Issues / other PRs related

  • Resolves #[Issue number for RC file detection enhancement]

Additional Information

The changes are focused on improving the robustness of RC file detection while maintaining the existing functionality and user experience.

Checklist

  • My code adheres to the coding and style guidelines of the project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no errors/warnings/merge conflicts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant