Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhancement: Rate mirrors heads up message #343

Merged
merged 1 commit into from
Sep 19, 2024

Conversation

jeevithakannan2
Copy link
Contributor

Pull Request

Title

Rate mirrors heads up message

Type of Change

  • UI/UX improvement

Description

I've noticed that users often cancel the script while rate-mirrors is running, due to the lack of a visible message indicating that the process is ongoing. This results in an empty mirrorlist making it a hell for linux newbies. Adding a heads-up message informing the user that the process may take a couple of seconds to complete can save the day for a linux rookie.

Checklist

  • My code adheres to the coding and style guidelines of the project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • My changes generate no errors/warnings/merge conflicts.

@jeevithakannan2 jeevithakannan2 force-pushed the rate-mirrors branch 2 times, most recently from 5c4d1b5 to 493fedf Compare September 11, 2024 17:57
@nnyyxxxx
Copy link
Contributor

@jeevithakannan2 You're going to have to rebase and rename the "commit linutil" to something else and remove the changes to the binary.

@jeevithakannan2
Copy link
Contributor Author

@jeevithakannan2 You're going to have to rebase and rename the "commit linutil" to something else and remove the changes to the binary.

Solved the issue

@nnyyxxxx
Copy link
Contributor

@jeevithakannan2 You're going to have to rebase and rename the "commit linutil" to something else and remove the changes to the binary.

Solved the issue

I wouldn't say the issue is solved, but you won't be given credit in that commit 493fedf since the author is Chris.

@nnyyxxxx
Copy link
Contributor

This PR looks good overall. 👍

@ChrisTitusTech
Copy link
Owner

Sorry for the inconvenience. We had a massive restructure of the codebase to improve future development. Because of this can you update your PR to the new structure. Thank you for your assistance and contribution.

@ChrisTitusTech ChrisTitusTech merged commit 23156bc into ChrisTitusTech:main Sep 19, 2024
1 check passed
@ChrisTitusTech ChrisTitusTech added the enhancement New feature or request label Sep 19, 2024
@jeevithakannan2 jeevithakannan2 deleted the rate-mirrors branch September 21, 2024 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants