Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add version checking & config migration for Alacritty #367

Closed

Conversation

adamperkowski
Copy link
Collaborator

@adamperkowski adamperkowski commented Sep 13, 2024

Add a version check & config migration for Alacritty
Merge PR #66 on dwm-titus first.

Type of Change

  • New feature
  • Bug fix

Description

Alacritty supports TOML config from version 0.13.0 and above. Changelog
Ref #364

Auto migrate from YAML to TOML for version newer or equal to 0.13.0 of alacritty

Issue related to PR

Checklist

  • My code adheres to the coding and style guidelines of the project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • My changes generate no errors/warnings/merge conflicts.

Copy link
Contributor

@nnyyxxxx nnyyxxxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@adamperkowski adamperkowski changed the title Add a version check for Alacritty Add version checking & config migration for Alacritty Sep 13, 2024
Auto migrate from YAML to TOML for alacritty >= 0.13.0

Co-authored-by: RazoBeckett <[email protected]>
@adamperkowski adamperkowski mentioned this pull request Sep 18, 2024
5 tasks
@github-actions github-actions bot added enhancement New feature or request bug Something isn't working labels Sep 18, 2024
@adamperkowski adamperkowski deleted the alacritty_v_check branch September 18, 2024 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

linutil doesn't handle old version of Alacrity
3 participants