Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed aarch64 from start.sh scripts #445

Closed

Conversation

adamperkowski
Copy link
Collaborator

@adamperkowski adamperkowski commented Sep 17, 2024

BEFORE MERGING THIS RECONSIDER ADDING ARM64 SUPPORT BACK #445 (comment)

Type of Change

  • Bug fix

Description

Linutil no longer supports ARM64. It's misleading to have start.sh try to download it and just not work.
Not clearly showing "Unsupported architecture" leads to confusion, confusion leads to research, possibly opening more duplicate issues, and overall waste of time.

Issue related to PR

Checklist

  • I have performed a self-review of my own code.
  • My changes generate no errors/warnings/merge conflicts.

Copy link
Contributor

@nnyyxxxx nnyyxxxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with this change, but there is another approach: Adding arrch64 ARM BACK in to linutil. I think this PR should be held off for now.

@adamperkowski
Copy link
Collaborator Author

adamperkowski commented Sep 17, 2024

but there is another approach: Adding arrch64 ARM BACK in to linutil. I think this PR should be held off for now.

I agree ARM support could be added back. Maintaining it is not so hard after all. I think @ChrisTitusTech sould decide.

@lj3954
Copy link
Contributor

lj3954 commented Sep 18, 2024

aarch64 was removed from the build workflow after it started failing in CI after #153 was merged. Why it failed? Nobody knows. I successfully built it on my system, and Chris built it on his; theoretically, there shouldn't be any difference in CI since cross uses a docker image.

Removing aarch64 from the start scripts is a pointless endeavour. Users of aarch64 systems will still try to launch the script, and be unable to due to the x86_64 binary downloaded being incompatible. Not really any better than pointing to an unresolvable URL. I think this PR should be closed.

@adamperkowski
Copy link
Collaborator Author

adamperkowski commented Sep 18, 2024

aarch64 was removed from the build workflow after it started failing in CI after #153 was merged. Why it failed? Nobody knows. I successfully built it on my system, and Chris built it on his; theoretically, there shouldn't be any difference in CI since cross uses a docker image.

Should be added back then.

Removing aarch64 from the start scripts is a pointless endeavour. Users of aarch64 systems will still try to launch the script, and be unable to due to the x86_64 binary downloaded being incompatible. Not really any better than pointing to an unresolvable URL. I think this PR should be closed.

I disagree. Not clearly showing "Unsupported architecture" leads to confusion, confusion leads to research, possibly opening more duplicate issues, and overall waste of time.

@github-actions github-actions bot added the bug Something isn't working label Sep 18, 2024
@adamperkowski adamperkowski deleted the startsh_arm64 branch September 18, 2024 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Does not work for aarch64 ARM Does not work for aarch64 ARM right now
4 participants