Remove duplicates from tui/cool_tips.txt & add a CI that checks the file
#600
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChrisTitusTech
approved these changes
Sep 22, 2024
|
I'd rather not bloat up CI for checking for dupes in a txt file that doesn't matter if it does dupe entries. We can look for the dupes manually and just PR that if it gets excessive. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removed duplicates from
tui/cool_tips.txt& added a CI that checks the file for duplicate entries.Testing
Tested, works.
Impact
The CI will work only on PRs or pushes that modify the file.
Checklist