📃 fix(system-cleanup): pacman orphan package removal #744
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamperkowski
force-pushed
the
pacman_orphans_removal_fix
branch
from
d098420 to
a911fe1
Compare
nnyyxxxx
reviewed
Oct 3, 2024
| @@ -23,7 +23,8 @@ cleanup_system() { | |||
| ;; | |||
| pacman) | |||
| "$ESCALATION_TOOL" "$PACKAGER" -Sc --noconfirm | |||
| "$ESCALATION_TOOL" "$PACKAGER" -Rns "$(pacman -Qtdq)" --noconfirm | |||
| # -Rns will return 1 if there are no packages provided | |||
There was a problem hiding this comment.
Suggested change
| # -Rns will return 1 if there are no packages provided |
|
ah i see the issue |
nnyyxxxx
reviewed
Oct 3, 2024
Co-authored-by: nyx <[email protected]>
adamperkowski
force-pushed
the
pacman_orphans_removal_fix
branch
from
24c6aa9 to
2f4f703
Compare
adamperkowski
changed the title
ChrisTitusTech
approved these changes
Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change]
Description
As you can see below, the script fails because:
-Rreturns1when there are no packages providedAll fixed here
Redirecting the output to
/dev/nullso the script's output doesn't get flooded.Testing
Works :)
Issues / other PRs related
Additional Information
Checklist
(📃 is a shell script btw)