implement a root check menu #927
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
i'm open to suggestions, list them if you have any |
jeevithakannan2
suggested changes
Nov 8, 2024
|
we should be following the srp principle, not inherently simplifying everything possible |
adamperkowski
approved these changes
Nov 8, 2024
|
@ChrisTitusTech we need to fix the xtask workflow |
No it's not broken. Someone didn't run xtask |
Nope. The docs are now in a different repo. This workflow is useless. |
|
i dropped the docs changes |
This comment was marked as outdated.
This comment was marked as outdated.
adamperkowski
approved these changes
Nov 11, 2024
lj3954
approved these changes
Nov 11, 2024
jeevithakannan2
approved these changes
Nov 11, 2024
ChrisTitusTech
approved these changes
Nov 11, 2024
jeevithakannan2
pushed a commit
to jeevithakannan2/linutil
that referenced
this pull request
Nov 11, 2024
* implement a root check menu * code needs to be readable * rephrase it a lil bit * disregard escalation tool variable if found as root * refactor: Call root check from within AppState constructor (ChrisTitusTech#7) * remove duplicate check * add comment back --------- Co-authored-by: Liam <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
implements a root check menu
this is a better implementation of the now closed #821
Testing