Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(common-service): runit support #985

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

feat(common-service): runit support #985

wants to merge 7 commits into from

Conversation

Jaredy899
Copy link

@Jaredy899 Jaredy899 commented Dec 24, 2024 •
edited
Loading

Type of Change

  • New feature
  • Bug fix
  • Documentation update
  • Refactoring
  • Hotfix
  • Security patch
  • UI/UX improvement

Description

I have updated the service script to address runit

Testing

Tested in Void Linux and Antix

Issues / other PRs related

Additional Information

Checklist

  • My code adheres to the coding and style guidelines of the project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no errors/warnings/merge conflicts.

@Jaredy899 Jaredy899 marked this pull request as ready for review December 24, 2024 12:55
@Jaredy899 Jaredy899 mentioned this pull request Dec 24, 2024
Closed
12 tasks
@adamperkowski adamperkowski changed the title Update common-service-script for runit feat(common-service): runit support Jan 2, 2025
@adamperkowski adamperkowski added the enhancement New feature or request label Jan 10, 2025
adamperkowski
adamperkowski requested changes Jan 10, 2025
View reviewed changes
core/tabs/common-service-script.sh Outdated Show resolved Hide resolved
@Jaredy899 Jaredy899 mentioned this pull request Jan 11, 2025
Open
12 tasks
adamperkowski
adamperkowski requested changes Jan 11, 2025
View reviewed changes
core/tabs/common-service-script.sh Outdated Show resolved Hide resolved
@Jaredy899 @adamperkowski
Update core/tabs/common-service-script.sh
a669ed3 
Cool with me. Thanks

Co-authored-by: Adam Perkowski <[email protected]>
adamperkowski
adamperkowski approved these changes Jan 11, 2025
View reviewed changes
Copy link
Collaborator

@adamperkowski adamperkowski left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Please take a look at this failing CI. It's complaining about formatting.

@Jaredy899 @adamperkowski
Update core/tabs/common-service-script.sh
9c71edf 
Found it faster than me. Thanks

Co-authored-by: Adam Perkowski <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cartercanedy cartercanedy cartercanedy left review comments

@adamperkowski adamperkowski adamperkowski approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Some Scripts Failing on non Systemd Debian Distributions
3 participants
@Jaredy899 @adamperkowski @cartercanedy