Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(config): cast config returned by getSystemValue to float as the function return type expects #634

Merged
merged 2 commits into from
Dec 28, 2023

Conversation

tcitworld
Copy link
Collaborator

Fixes: OCA\Sentry\Config::getSamplingRate(): Return value must be of type float, string returned

…unction return type expects

Fixes: OCA\Sentry\Config::getSamplingRate(): Return value must be of type float, string returned

Signed-off-by: Thomas Citharel <[email protected]>
@tcitworld tcitworld added bug 3. to review php Pull requests that update Php code labels Nov 24, 2023
@ChristophWurst ChristophWurst merged commit d8cf812 into master Dec 28, 2023
29 checks passed
@ChristophWurst ChristophWurst deleted the config-sampling-rate-float branch December 28, 2023 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review bug php Pull requests that update Php code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants