feat: Add profiles_sample_rate #640
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChristophWurst
approved these changes
Dec 28, 2023
|
CI failure seems unrelated, could be either handled by using --force to enable the app or bump the max-version to 29 already, not sure what you prefer @ChristophWurst |
|
Let's just add 29: #641 |
Signed-off-by: Julius Härtl <[email protected]>
ChristophWurst
force-pushed
the
enh/profiling
branch
from
dbc02db to
1238dfa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To make use of https://docs.sentry.io/platforms/php/profiling/
I've been running that for quite a while on my personal instance and seems quite nice to get some more insights, though I haven't been extensively using the results yet (as I forgot I had deployed that 🙈 )