new insert_srid arg, and assert self.srid is not None for writes

geopetl/oracle_sde.py

@@ -849,7 +849,7 @@ def write(self, rows, srid=None, table_srid=None,
         # TODO some tables just don't have a srid -- this should probably go
         # somewhere else, or needs more logic
         #######################################################################
-        # table_srid = table_srid or self.srid
+        table_srid = table_srid or self.srid
         # if table_srid is None:
         #     raise ValueError('Table does not define an SRID. Please provide '
         #                         'a value for `table_srid` or register the '
@@ -960,6 +960,11 @@ def write(self, rows, srid=None, table_srid=None,
         for field in fields:
             type_ = type_map[field]
             if type_ == 'geom':
+                # SRID cannot be None here! This will result in this being used in the prepare statment:
+                #SDE.ST_GEOMETRY(:SHAPE, NONE))
+                # which ends with this error: cx_Oracle.DatabaseError: ORA-00984: column not allowed here
+                print('Making sure we have an SRID value..')
+                assert self.srid, "SRID cannot be None for the write method!"
                 geom_placeholder = 'SDE.ST_Geometry(:{}, {})'\
                                         .format(field, self.srid)
                 placeholders.append(geom_placeholder)
@@ -1011,6 +1016,7 @@ def write(self, rows, srid=None, table_srid=None,
         stmt_fields_joined = ', '.join(stmt_fields)
         prepare_stmt = "INSERT INTO {} ({}) VALUES ({})".format(self._name_with_schema, \
             stmt_fields_joined, placeholders_joined)
+        print(f'prepare_stmt: {prepare_stmt}')
         self.db.cursor.prepare(prepare_stmt)
 
         db_types_filtered = {x.upper(): db_types.get(x.upper()) for x in stmt_fields if x != self.objectid_field}