Added wasm and created extract_table_names method #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| extern { pub fn alert(s: &str); } | ||
|
|
||
| #[wasm_bindgen] | ||
| pub fn extract_table_names(sql: String) -> JsValue { |
There was a problem hiding this comment.
@Anks I'm not sure which is the best option here monadic error handling or raising alerts.
type Error = String;
pub fn extract_table_names(sql: String) -> (Error, JsValue)
There was a problem hiding this comment.
For now, I have just made the function return a string (in case of error) or an array of strings in case of success. Not a great interface, but it allows the caller to distinguish between parsing failure and empty state
Return value = string: parsing failed, this is the error message Return value = array: parsing succeeded, these are table names
…ry as well as wasm versions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.