Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for MultiDatasetTradingEnv #29

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

sachetz
Copy link

@sachetz sachetz commented Dec 12, 2024

In TradingEnv, the options parameter in the reset method is not used, so I kept that consistent for MultiDatasetTradingEnv as well.

For the dataset selection issue, the following selects the dataset that is used the least times at each step.

potential_dataset_pathes = np.where(self.dataset_nb_uses == self.dataset_nb_uses.min())[0]
random_int = np.random.choice(potential_dataset_pathes)
dataset_path = self.dataset_pathes[random_int]

I have tested this out for a personal project.

…ility with gymnasium==1.0.0 and issues in selection of multi-dataset
@sachetz
Copy link
Author

sachetz commented Dec 12, 2024

These are implemented fixes for Issue #28

@sachetz sachetz changed the title Fixes for issue #28 Fixes for MultiDatasetTradingEnv Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants