Fix support for Metabase CI and future-proof DDL statements #273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisptrutski
commented
Sep 30, 2024
|
|
||
| (defmethod sql.tx/pk-sql-type :clickhouse [_] "Int32") | ||
|
|
||
| (defmethod sql.tx/add-fk-sql :clickhouse [& _] nil) | ||
|
|
||
| (defmethod sql.tx/session-schema :clickhouse [_] "default") | ||
|
|
||
| (defmethod tx/supports-time-type? :clickhouse [_driver] false) |
There was a problem hiding this comment.
This is replaced by the :test/time-type feature.
crisptrutski
commented
Oct 1, 2024
crisptrutski
force-pushed
the
test-fixes
branch
from
523c8fa to
3543dfc
Compare
Shall we wait until 0.51 and merge after that? |
I think after metabase/metabase#48233 merges we'll be good to release after its following point release. Will rerun the suite locally after the backport is merged. |
3 tasks
|
The upload test suite is fully passing with this change on v50 now 😄 (The changes to test/data need to be rolled back to run them though) |
slvrtrn
approved these changes
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR started as future proofing for an upcoming HoneySQL update which requires explicit quoting of identifiers in some cases.
As part of this work I got the main Metabase upload's test suite running against the driver. This required some updates to the driver to track interface changes, and also revealed some small bugs, which have also been fixed.
NOTE: this version will not be safe for v50 without further changes.Confirmed that this works with the upcoming version of v50.Checklist