Task 986: update contributors guide #1086
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@CodeWritingCow Just pinging you since I saw this didn't have a reviewer assigned! |
CodeWritingCow
approved these changes
Jan 20, 2025
There was a problem hiding this comment.
@millmason looks good to me. Thanks for updating the guide! It'll help other contributors make PRs to the right branch now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHAT:
We add instructions into the
CONTRIBUTING.mddoc that users should base PRs off of the staging branch and not the main branch.WHY:
Per @CodeWritingCow , it looks like these instructions were previously present but may have been accidentally removed in fb93130.
No testing required, but any feedback on content/clarity/wording is welcome! I tried to smoothly integrate the original language from the above commit into the current format.