Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch from errors to alerts so oauth-related flashes will show #362

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Switch from errors to alerts so oauth-related flashes will show #362

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions app/controllers/services_controller.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ def create
sign_in_and_redirect(:user, user)
end
else
flash[:error] = service_route.capitalize + ' cannot be used to sign up on CodeMontage as no valid email address has been provided. Please add a public email address or sign up manually. If you already have an account, you can sign in and add ' + service_route.capitalize + ' from your profile.'
flash[:alert] = service_route.capitalize + ' cannot be used to sign up on CodeMontage as no valid email address has been provided. Please add a public email address or sign up manually. If you already have an account, you can sign in and add ' + service_route.capitalize + ' from your profile.'
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line is too long. [309/80]
Unnecessary spacing detected.
Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

redirect_to new_user_session_path
end
end
Expand All @@ -95,11 +95,11 @@ def create
end
end
else
flash[:error] = service_route.capitalize + ' returned invalid data for the user id.'
flash[:alert] = service_route.capitalize + ' returned invalid data for the user id.'
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line is too long. [93/80]
Unnecessary spacing detected.
Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

redirect_to new_user_session_path
end
else
flash[:error] = 'Error while authenticating via ' + service_route.capitalize + '.'
flash[:alert] = 'Error while authenticating via ' + service_route.capitalize + '.'
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line is too long. [88/80]
Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

redirect_to new_user_session_path
end
end
Expand Down