-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding filter for tags #379
base: master
Are you sure you want to change the base?
Adding filter for tags #379
Conversation
…n the Event model
…nd 'Join Us' for past events
Added all projects button to navigation
Link to issue template & include requisite emojis in the README
…rking as intended.
…ing to index.html.erb
@@ -0,0 +1,18 @@ | |||
window.onload = function() { | |||
var tags = []; | |||
var href = window.location.origin + window.location.pathname |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing semicolon.
} else { | ||
window.location.href = href +"?tags=" + this.value; | ||
} | ||
}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unnecessary semicolon.
tags = document.getElementsByClassName("tag_radio"); | ||
|
||
for (var i = 0; i < tags.length; i++) { | ||
tags[i].addEventListener("click", tagLoop) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing semicolon.
} else { | ||
window.location.href = href +"?tags=" + this.value; | ||
} | ||
}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unnecessary semicolon.
@@ -11,4 +11,24 @@ def project_tags_link_list(project, type) | |||
link_to tag.name, projects_path(tags: tag.name) | |||
end.join(', ').html_safe | |||
end | |||
|
|||
def projects_tech_and_cause_tags_lists(projects_array) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Assignment Branch Condition size for projects_tech_and_cause_tags_lists is too high. [15.26/15]
Creates two bars of tag filters for the project page. One for Technology tags and one for Cause tags.
I am not 100% sure why the old commits are being recommited.. If someone knows a fix I am more than happy to fix it! I don't foresee any issues with them though as they will already have taken effect in master.