Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/investment resizable layout #86

Merged

Conversation

miralsuthar
Copy link

Description

This PR fixes the bug.

What type of PR is this? (check all applicable)

  • πŸ’‘ Feature
  • πŸ› Bug Fix
  • πŸ“ Documentation Update
  • 🎨 Style
  • πŸ§‘β€πŸ’» Code Refactor
  • πŸ”₯ Performance Improvements
  • βœ… Test
  • πŸ€– Build
  • πŸ” CI
  • πŸ“¦ Chore (Release)
  • ⏩ Revert

Related Tickets & Documents

Please use this format link issue numbers: Fixes #42

Mobile & Desktop Screenshots/Recordings

Screenshot 2024-01-25 at 6 39 13β€―PM

Steps to QA

  1. Visit to dashboard
  2. Click on Investment
  3. Check if the layout is middle partition.

Added to documentation?

  • πŸ“œ README.md
  • πŸ™… no documentation needed

[optional] Are there any post-deployment tasks we need to perform?

[optional] What gif best describes this PR or how it makes you feel?

Change the cookies setter key name for investment page resizable layout from `react-resizable-panels:layout` to `react-resizable-panels:layout-investment`.
Copy link

vercel bot commented Jan 25, 2024

Someone is attempting to deploy a commit to a Personal Account owned by @meglerhagen on Vercel.

@meglerhagen first needs to authorize it.

@miralsuthar miralsuthar marked this pull request as draft January 25, 2024 13:10
@miralsuthar miralsuthar marked this pull request as ready for review January 25, 2024 13:22
@miralsuthar
Copy link
Author

Hey @meglerhagen,

I think this will solve the layout issue. let me know If this need changes.

@Codehagen
Copy link
Owner

Hi @miralsuthar! Going to look at is. Is it possible that we try to take this into the turborepo? Have have refractored a lot of the code ✨

@Codehagen
Copy link
Owner

Yes! This solved this issue 🀩
image

Is it possible that you would like to help with the rest of the pages to implement this?

Also, Could we make the left nav a little smaller width as default?

Copy link
Owner

@Codehagen Codehagen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This worked! If we could see on the other pages also that would be πŸ’―

@Codehagen
Copy link
Owner

Also, it was a format error with a space. Just remember to yarn format before the next PR ✨

@miralsuthar
Copy link
Author

Yes! This solved this issue 🀩 image

Is it possible that you would like to help with the rest of the pages to implement this?

Also, Could we make the left nav a little smaller width as default?

Sure I can do that, to make the nav bar size smaller and also default as small.

@miralsuthar
Copy link
Author

Also, it was a format error with a space. Just remember to yarn format before the next PR ✨

Got it, thank you.

@miralsuthar miralsuthar requested a review from Codehagen February 2, 2024 05:21
Copy link
Owner

@Codehagen Codehagen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, merging now.

@Codehagen Codehagen merged commit 2a33c7e into Codehagen:main Feb 2, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improvement: Centralized Default Position for Handle Panel:
2 participants