-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Wellplate change size after creation #2123
base: main
Are you sure you want to change the base?
Conversation
LCOV of commit
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After the size is set, it cannot be changed again.
Wasn't this what this PR was supposed to implement? I.e., wasn't the goal to enable changing wellplate-size even after creation?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe the instructions in red are off by one? I.e., The red instructions should go away when I enter "0" or "100" ?
Maybe also replace 0 with 1, since 0 doesn't make a lot of sense from a user perspective.
Other than that the changes seem to be working well in the UI. However, I'm not quite sure if this PR solves the original problem, i.e., to enable changing wellplate size at any time.
app/packs/src/apps/mydb/elements/details/wellplates/propertiesTab/WellplateSizeDropdown.js
Outdated
Show resolved
Hide resolved
.../packs/src/apps/mydb/elements/details/wellplates/propertiesTab/WellplateSizeDropdown.spec.js
Outdated
Show resolved
Hide resolved
LCOV of commit
|
LCOV of commit
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I confirm that the UI works as intended now.
User is now able to create a wellplate without defining the size (entry: "not yet chosen").
After the creation the user can modify the wellplate to set a predefined or custom size and save it.
After the size is set, it cannot be changed again. When the size is set, the users is notified, that it cannot be changed.