Skip to content

Improving NotificationsHandler & NotificationsService with more BL #18

Improving NotificationsHandler & NotificationsService with more BL

Improving NotificationsHandler & NotificationsService with more BL #18

Triggered via push November 28, 2023 15:46
Status Success
Total duration 20s
Artifacts

phpcs.yml

on: push
Fit to window
Zoom out
Zoom in

Annotations

10 errors and 10 warnings
build: src/CustomerNotificationsBundle.php#L5
The tag in position 1 should be the @category tag
build: src/CustomerNotificationsBundle.php#L5
Content of the @author tag must be in the form "Display Name <[email protected]>"
build: src/CustomerNotificationsBundle.php#L6
The tag in position 2 should be the @author tag
build: src/CustomerNotificationsBundle.php#L8
The tag in position 3 should be the @license tag
build: src/Service/InstallationService.php#L2
Missing file doc comment
build: src/Service/InstallationService.php#L12
Tag value for @author tag indented incorrectly; expected 1 spaces but found 2
build: src/Service/InstallationService.php#L89
There must be no blank line following an inline comment
build: src/Service/InstallationService.php#L101
No space found before comment text; expected "// This is the place where you can add or change Installation data from/for this bundle or other required bundles." but found "//This is the place where you can add or change Installation data from/for this bundle or other required bundles."
build: src/Service/InstallationService.php#L102
No space found before comment text; expected "// Note that in most cases it is recommended to use .json files in the Installation folder instead, if possible." but found "//Note that in most cases it is recommended to use .json files in the Installation folder instead, if possible."
build: src/Service/InstallationService.php#L102
There must be no blank line following an inline comment
build: src/ActionHandler/NotificationsHandler.php#L49
Line exceeds 125 characters; contains 135 characters
build: src/Service/NotificationsService.php#L140
Line exceeds 125 characters; contains 131 characters
build: src/Service/NotificationsService.php#L140
Comment refers to a TODO task "improve response, depending on what this notification triggered? ',email send, ContactMoment Object created', etc"
build: src/Service/NotificationsService.php#L193
Comment refers to a TODO task "Maybe we could/should support multiple Sources instead of one?"
build: src/Service/NotificationsService.php#L218
Line exceeds 125 characters; contains 146 characters
build: src/Service/NotificationsService.php#L229
Line exceeds 125 characters; contains 127 characters
build: src/Service/NotificationsService.php#L247
Comment refers to a TODO task "duplicate code with sms?"
build: src/Service/NotificationsService.php#L249
Comment refers to a TODO task
build: src/Service/NotificationsService.php#L284
Comment refers to a TODO task "duplicate code with email?"
build: src/Service/NotificationsService.php#L286
Comment refers to a TODO task