Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Defined notes for BSI SYS.1.6.A17 #12530

Closed

Conversation

lichtblaugue
Copy link

Description:

Added notes and controls for BSI SYS.1.6 A17

Rationale:

As we have multiple customers asking for a BSI profile to be included in the compliance-operator, we are contributing a profile. To provide a better review process, the individual controle are implemented as separate PRs.

Copy link

openshift-ci bot commented Oct 23, 2024

Hi @lichtblaugue. Thanks for your PR.

I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci openshift-ci bot added the needs-ok-to-test Used by openshift-ci bot. label Oct 23, 2024
Copy link

github-actions bot commented Oct 23, 2024

Start a new ephemeral environment with changes proposed in this pull request:

ocp4 (from CTF) Environment (using Fedora as testing environment)
Open in Gitpod

Fedora Testing Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

@jan-cerny jan-cerny added the OpenShift OpenShift product related. label Oct 25, 2024
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please do not add the same content, which is already existing in other PRs / commits. just rebase on that branch or wait until the other branch is merged

Copy link

github-actions bot commented Nov 6, 2024

This datastream diff is auto generated by the check Compare DS/Generate Diff

Click here to see the full diff
New content has different text for rule 'xccdf_org.ssgproject.content_rule_general_node_separation'.
--- xccdf_org.ssgproject.content_rule_general_node_separation
+++ xccdf_org.ssgproject.content_rule_general_node_separation
@@ -15,5 +15,8 @@
 [reference]:
 SYS.1.6.A3
 
+[reference]:
+SYS.1.6.A26
+
 [rationale]:
 Assigning workloads with high protection requirements to specific nodes creates and additional boundary (the node) between workloads of high protection requirements and workloads which might follow less strict requirements. An adversary which attacked a lighter protected workload now has additional obstacles for their movement towards the higher protected workloads.

New content has different text for rule 'xccdf_org.ssgproject.content_rule_scc_drop_container_capabilities'.
--- xccdf_org.ssgproject.content_rule_scc_drop_container_capabilities
+++ xccdf_org.ssgproject.content_rule_scc_drop_container_capabilities
@@ -37,6 +37,9 @@
 APP.4.4.A9
 
 [reference]:
+SYS.1.6.A17
+
+[reference]:
 2.2.1
 
 [reference]:

New content has different text for rule 'xccdf_org.ssgproject.content_rule_scc_limit_container_allowed_capabilities'.
--- xccdf_org.ssgproject.content_rule_scc_limit_container_allowed_capabilities
+++ xccdf_org.ssgproject.content_rule_scc_limit_container_allowed_capabilities
@@ -74,6 +74,9 @@
 APP.4.4.A9
 
 [reference]:
+SYS.1.6.A17
+
+[reference]:
 2.2.1
 
 [reference]:

New content has different text for rule 'xccdf_org.ssgproject.content_rule_scc_limit_host_dir_volume_plugin'.
--- xccdf_org.ssgproject.content_rule_scc_limit_host_dir_volume_plugin
+++ xccdf_org.ssgproject.content_rule_scc_limit_host_dir_volume_plugin
@@ -27,6 +27,9 @@
 APP.4.4.A9
 
 [reference]:
+SYS.1.6.A17
+
+[reference]:
 CNTR-OS-000660
 
 [reference]:

New content has different text for rule 'xccdf_org.ssgproject.content_rule_scc_limit_host_ports'.
--- xccdf_org.ssgproject.content_rule_scc_limit_host_ports
+++ xccdf_org.ssgproject.content_rule_scc_limit_host_ports
@@ -21,6 +21,9 @@
 APP.4.4.A9
 
 [reference]:
+SYS.1.6.A17
+
+[reference]:
 CNTR-OS-000660
 
 [reference]:

New content has different text for rule 'xccdf_org.ssgproject.content_rule_scc_limit_ipc_namespace'.
--- xccdf_org.ssgproject.content_rule_scc_limit_ipc_namespace
+++ xccdf_org.ssgproject.content_rule_scc_limit_ipc_namespace
@@ -39,6 +39,9 @@
 APP.4.4.A9
 
 [reference]:
+SYS.1.6.A17
+
+[reference]:
 2.2.1
 
 [reference]:

New content has different text for rule 'xccdf_org.ssgproject.content_rule_scc_limit_net_raw_capability'.
--- xccdf_org.ssgproject.content_rule_scc_limit_net_raw_capability
+++ xccdf_org.ssgproject.content_rule_scc_limit_net_raw_capability
@@ -40,6 +40,9 @@
 APP.4.4.A9
 
 [reference]:
+SYS.1.6.A17
+
+[reference]:
 2.2.1
 
 [reference]:

New content has different text for rule 'xccdf_org.ssgproject.content_rule_scc_limit_network_namespace'.
--- xccdf_org.ssgproject.content_rule_scc_limit_network_namespace
+++ xccdf_org.ssgproject.content_rule_scc_limit_network_namespace
@@ -39,6 +39,9 @@
 APP.4.4.A9
 
 [reference]:
+SYS.1.6.A17
+
+[reference]:
 2.2.1
 
 [reference]:

New content has different text for rule 'xccdf_org.ssgproject.content_rule_scc_limit_privilege_escalation'.
--- xccdf_org.ssgproject.content_rule_scc_limit_privilege_escalation
+++ xccdf_org.ssgproject.content_rule_scc_limit_privilege_escalation
@@ -37,6 +37,9 @@
 APP.4.4.A9
 
 [reference]:
+SYS.1.6.A17
+
+[reference]:
 2.2.1
 
 [reference]:

New content has different text for rule 'xccdf_org.ssgproject.content_rule_scc_limit_privileged_containers'.
--- xccdf_org.ssgproject.content_rule_scc_limit_privileged_containers
+++ xccdf_org.ssgproject.content_rule_scc_limit_privileged_containers
@@ -42,6 +42,9 @@
 APP.4.4.A9
 
 [reference]:
+SYS.1.6.A17
+
+[reference]:
 2.2.1
 
 [reference]:

New content has different text for rule 'xccdf_org.ssgproject.content_rule_scc_limit_process_id_namespace'.
--- xccdf_org.ssgproject.content_rule_scc_limit_process_id_namespace
+++ xccdf_org.ssgproject.content_rule_scc_limit_process_id_namespace
@@ -39,6 +39,9 @@
 APP.4.4.A9
 
 [reference]:
+SYS.1.6.A17
+
+[reference]:
 2.2.1
 
 [reference]:

New content has different text for rule 'xccdf_org.ssgproject.content_rule_scc_limit_root_containers'.
--- xccdf_org.ssgproject.content_rule_scc_limit_root_containers
+++ xccdf_org.ssgproject.content_rule_scc_limit_root_containers
@@ -39,6 +39,9 @@
 APP.4.4.A9
 
 [reference]:
+SYS.1.6.A17
+
+[reference]:
 2.2.1
 
 [reference]:

Copy link

codeclimate bot commented Nov 6, 2024

Code Climate has analyzed commit c880d3b and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 60.9% (0.0% change).

View more on Code Climate.

@yuumasato yuumasato self-assigned this Nov 28, 2024
@yuumasato
Copy link
Member

/ok-to-test

@openshift-ci openshift-ci bot added the ok-to-test Used by openshift-ci bot. label Nov 28, 2024
@yuumasato
Copy link
Member

/test 4.17-e2e-aws-ocp4-bsi
/test 4.17-e2e-aws-ocp4-bsi-node
/test 4.17-e2e-aws-rhcos4-bsi

@openshift-ci openshift-ci bot removed the needs-ok-to-test Used by openshift-ci bot. label Nov 28, 2024
Copy link

openshift-ci bot commented Nov 28, 2024

@lichtblaugue: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/4.17-e2e-aws-ocp4-bsi c880d3b link true /test 4.17-e2e-aws-ocp4-bsi

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

oc apply -f ${ROOT_DIR}/ocp-resources/e2e/sandboxed-containers-instance.yaml --server-side=true

echo "check, that the mcp was updated"
oc wait --for=condition=Updated --timeout=3600s machineconfigpool/kata-oc
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before waiting for the mcp to be updated, this script needs to wait for the mcp to exist.
Similar to what was done in line 10.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @yuumasato ,

this PR should not include https://github.com/ComplianceAsCode/content/pull/12530/files/8e36b6428e1e65122ec3aa8b1cac0284c06c1ad1..14ae93f598e984653248f96215f068f6f746d2e4

as this is done in #12494

I will help @lichtblaugue to remove this commits from the PR and consider your comment in the pull/12494

@lichtblaugue
Copy link
Author

Closing in favor of
#12663

@yuumasato yuumasato added the BSI PRs or issues for the BSI profile. label Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BSI PRs or issues for the BSI profile. ok-to-test Used by openshift-ci bot. OpenShift OpenShift product related.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants