Ubuntu 24.04 5.3.3.4.4 Ensure pam_unix includes use_authtok

[ericeberry]

Description:

• Ubuntu 24.04 5.3.3.4.4 Ensure pam_unix includes use_authtok

Rationale:

• Implement Ubuntu 24.04 5.3.3.4.4 Ensure pam_unix includes use_authtok

[openshift-ci]

Hi @ericeberry. Thanks for your PR.

I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[github-actions]

Start a new ephemeral environment with changes proposed in this pull request:

ubuntu2404 (from CTF) Environment (using Fedora as testing environment)

Fedora Testing Environment

Oracle Linux 8 Environment

[github-actions]

This datastream diff is auto generated by the check Compare DS/Generate Diff

Click here to see the full diff

bash remediation for rule 'xccdf_org.ssgproject.content_rule_accounts_password_pam_unix_enabled' differs.
--- xccdf_org.ssgproject.content_rule_accounts_password_pam_unix_enabled
+++ xccdf_org.ssgproject.content_rule_accounts_password_pam_unix_enabled
@@ -8,8 +8,8 @@
     if [ -f "$conf_path"/unix ]; then
         if grep -q "$(md5sum "$conf_path"/unix | cut -d ' ' -f 1)" /var/lib/dpkg/info/libpam-runtime.md5sums;then
             cp "$conf_path"/unix "$conf_path"/"$conf_name"
-            sed -i '/Default: yes/a Priority: 257\
-Conflicts: unix' "$conf_path"/"$conf_name"
+            sed -i 's/Priority: [0-9]\+/Priority: 257\
+Conflicts: unix/' "$conf_path"/"$conf_name"
             DEBIAN_FRONTEND=noninteractive pam-auth-update
         else
             echo "Not applicable - checksum of $conf_path/unix does not match the original." >&2

[codeclimate]

Code Climate has analyzed commit 1331b24 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 61.6% (0.0% change).

View more on Code Climate.

[mpurg]

Lgtm

[mpurg]

This change is a fix for all rules using the bash_pam_unix_enable macro. Please add a note to the description.

[dodys]

lgtm, thanks!

[dodys]

the ctests are failing, could you please take a look?
Also the tests are failing in 24.04.

[mpurg]

@dodys ctest issue was fixed in #12796

[mpurg]

@ericeberry One of the tests is failing, can you look into it please? https://github.com/ComplianceAsCode/content/actions/runs/12660335702/job/35281436920?pr=12760

[ericeberry]

@ericeberry One of the tests is failing, can you look into it please? https://github.com/ComplianceAsCode/content/actions/runs/12660335702/job/35281436920?pr=12760

Yes. I am working on that one.