Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ubuntu 24.04: Implement 5.3.3.4.1 Ensure pam_unix does not include nullok #12770

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Ubuntu 24.04: Implement 5.3.3.4.1 Ensure pam_unix does not include nullok #12770

wants to merge 8 commits into from
+111 −11

Conversation

alanmcanonical
Copy link
Contributor

@alanmcanonical alanmcanonical commented Jan 2, 2025 •
edited
Loading

Description:

  • Implement 5.3.3.4.1 Ensure pam_unix does not include nullok
  • Add package applicability of pam
  • Make sure nullok is removed to avoid pam-auth keeping the original parameters
  • Remove the additional Priority line in bash macro bash_pam_unix_enable which improves Ubuntu enable unix #12660

Rationale:

  • Satisfies Ubuntu 24.04 CIS control 5.3.3.4.1
  • The remediation requires pam package in Ubuntu 24.04
  • The pam-auth-update will keep the existing parameter

@alanmcanonical alanmcanonical requested a review from a team as a code owner January 2, 2025 17:16
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Jan 2, 2025

Hi @alanmcanonical. Thanks for your PR.

I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci openshift-ci bot added the needs-ok-to-test Used by openshift-ci bot. label Jan 2, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 2, 2025

Start a new ephemeral environment with changes proposed in this pull request:

rhel8 (from CTF) Environment (using Fedora as testing environment)
Open in Gitpod

Fedora Testing Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

@dodys dodys self-assigned this Jan 6, 2025
@dodys dodys added Ubuntu Ubuntu product related. Update Profile Issues or pull requests related to Profiles updates. CIS CIS Benchmark related. Update Rule Issues or pull requests related to Rules updates. labels Jan 6, 2025
@dodys dodys added this to the 0.1.76 milestone Jan 6, 2025
@alanmcanonical alanmcanonical force-pushed the ubt24_53341 branch 2 times, most recently from d55d84f to be86b98 Compare January 6, 2025 23:02
mpurg
mpurg reviewed Jan 8, 2025
View reviewed changes
shared/macros/10-bash.jinja Outdated
@@ -913,6 +913,7 @@ if [ ! -f "$conf_path"/"$conf_name" ]; then
if [ -f "$conf_path"/unix ]; then
if grep -q "$(md5sum "$conf_path"/unix | cut -d ' ' -f 1)" /var/lib/dpkg/info/libpam-runtime.md5sums;then
cp "$conf_path"/unix "$conf_path"/"$conf_name"
sed '/Priority: 256/d' "$conf_path"/"$conf_name"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This conflicts with https://github.com/ComplianceAsCode/content/pull/12760/files#diff-ceb4cfe1967c5bfeb9083cc90cb611d6983fbf1b36c5a04867fd4616fdebd177L916

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reverted. Thanks

@alanmcanonical alanmcanonical mentioned this pull request Jan 9, 2025
Merged
@codeclimate CodeClimate
Copy link

codeclimate bot commented Jan 10, 2025

Code Climate has analyzed commit 4f1d6b3 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 61.8% (0.1% change).

View more on Code Climate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mpurg mpurg mpurg left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@dodys dodys

Labels
CIS CIS Benchmark related. needs-ok-to-test Used by openshift-ci bot. Ubuntu Ubuntu product related. Update Profile Issues or pull requests related to Profiles updates. Update Rule Issues or pull requests related to Rules updates.
Projects
None yet
Milestone
0.1.76
Development

Successfully merging this pull request may close these issues.
3 participants
@alanmcanonical @mpurg @dodys