-
Notifications
You must be signed in to change notification settings - Fork 706
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the _rule_id and var access in template.py of pam_account_password_faillock #12778
Fix the _rule_id and var access in template.py of pam_account_password_faillock #12778
Conversation
Hi @alanmcanonical. Thanks for your PR. I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@@ -11,6 +11,6 @@ def preprocess(data, lang): | |||
type(data.get(var)) != int: | |||
errmsg = ("The template instance of the rule {0} requires the " | |||
"parameter {1} is either 'use_ext_variable' or " | |||
"a number or undefined".formate(_rule_id, var)) | |||
"a number or undefined".formate(data["_rule_id"], date["var"])) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"a number or undefined".formate(data["_rule_id"], date["var"])) | |
"a number or undefined".format(data["_rule_id"], data["var"])) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@alanmcanonical you still have date instead of data there
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed the date typo
6f65518
to
f92ed0d
Compare
Code Climate has analyzed commit f92ed0d and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 61.6% (0.0% change). View more on Code Climate. |
Description: