Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the _rule_id and var access in template.py of pam_account_password_faillock #12778

Merged

Conversation

alanmcanonical
Copy link
Contributor

Description:

  • Fix the _rule_id and var access in template.py of pam_account_password_faillock template

@openshift-ci openshift-ci bot added the needs-ok-to-test Used by openshift-ci bot. label Jan 6, 2025
Copy link

openshift-ci bot commented Jan 6, 2025

Hi @alanmcanonical. Thanks for your PR.

I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

github-actions bot commented Jan 6, 2025

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

@@ -11,6 +11,6 @@ def preprocess(data, lang):
type(data.get(var)) != int:
errmsg = ("The template instance of the rule {0} requires the "
"parameter {1} is either 'use_ext_variable' or "
"a number or undefined".formate(_rule_id, var))
"a number or undefined".formate(data["_rule_id"], date["var"]))
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"a number or undefined".formate(data["_rule_id"], date["var"]))
"a number or undefined".format(data["_rule_id"], data["var"]))

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alanmcanonical you still have date instead of data there

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed the date typo

@jan-cerny jan-cerny self-assigned this Jan 6, 2025
@jan-cerny jan-cerny added this to the 0.1.76 milestone Jan 6, 2025
@alanmcanonical alanmcanonical force-pushed the fix_rule_id_templatepy branch from 6f65518 to f92ed0d Compare January 6, 2025 16:59
Copy link

codeclimate bot commented Jan 6, 2025

Code Climate has analyzed commit f92ed0d and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 61.6% (0.0% change).

View more on Code Climate.

@jan-cerny jan-cerny merged commit bd7581c into ComplianceAsCode:master Jan 7, 2025
98 of 99 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-ok-to-test Used by openshift-ci bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants