fix(InstagramEmbed): position slices for caption content *inside* the embed #1773
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests were previously incorrectly having the slice of the instagram embed run over the embed itself. I failed to catch this in the snapshot tests, but encountered this when testing embedding by pasting in the Instagram embed code directly into a text editor and it rendering as nothing. 😭
Relevant lines that fix the code are:
https://github.com/CondeNast/atjson/blob/ad4d15371d997a4978879588e9f90e796c5b7adb/packages/%40atjson/source-html/src/converter/social-embeds.ts