Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref: Config Schema (+ tests!) #11

Merged
merged 12 commits into from
Aug 28, 2024
Merged

ref: Config Schema (+ tests!) #11

merged 12 commits into from
Aug 28, 2024

Conversation

mgaeta
Copy link
Contributor

@mgaeta mgaeta commented Aug 16, 2024

Description

  • Update everything in go.mod to latest
  • Use new config schema for validation
  • Add unit tests

TODO

  • Decide how to handle empty flags
  • Fix comma-separated issue
  • Move test infrastructure to baton-sdk

@mgaeta mgaeta requested review from ggreer and mchavez August 16, 2024 01:13
@mgaeta mgaeta self-assigned this Aug 16, 2024
@ggreer
Copy link
Contributor

ggreer commented Aug 20, 2024

I think you'll have to re-push to this branch to trigger tests.

@mgaeta mgaeta force-pushed the marcos/ref/config-schema branch from 6878385 to 9ec53e2 Compare August 20, 2024 16:59
@mgaeta mgaeta force-pushed the marcos/ref/config-schema branch from 57566c5 to 489596d Compare August 22, 2024 20:28
@mgaeta mgaeta force-pushed the marcos/ref/config-schema branch from 489596d to f16be6a Compare August 22, 2024 20:30
@ggreer
Copy link
Contributor

ggreer commented Aug 23, 2024

It'd be nice to fix the last linter error, but feel free to merge this and make a new PR. Whatever's easiest.

@mgaeta mgaeta merged commit 0eb3944 into main Aug 28, 2024
3 checks passed
@mgaeta mgaeta deleted the marcos/ref/config-schema branch August 28, 2024 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants