Migrate configuration

[shackra]

Pull Request

To help us get this pull request reviewed and merged quickly, please be sure to include the following items:

• Tests (if applicable)
• Documentation (if applicable)
• Changelog entry
• A full explanation here in the PR description of the work done

PR Type

What kind of change does this PR introduce?

• Bugfix
• Feature
• Code style update (formatting, local variables)
• Refactoring (no functional changes, no api changes)
• Build related changes
• CI related changes
• Documentation content changes
• Tests
• Other

Backward Compatibility

Is this change backward compatible with the most recently released version? Does it introduce changes which might change the user experience in any way? Does it alter the Connector in any way?

• Yes (backward compatible)
• No (breaking changes)

Useful links:

• [https://github.com/ConductorOne/baton-sdk/wiki/Coding-Guidelines](Baton SDK coding guidelines)
• [https://github.com/ConductorOne/baton/blob/main/CONTRIBUTING.md](New contributor guide)

Issue Linking

What's new?

[mgaeta]

https://www.jenkins.io/doc/book/system-administration/authenticating-scripted-clients/
I think the password and token are basically interchangeable

func WithSetBasicAuthHeader(username, password string) uhttp.RequestOption {
	return uhttp.WithHeader("Authorization", "Basic "+basicAuth(username, password))
}

func WithSetTokenAuthHeader(username, token string) uhttp.RequestOption {
	return uhttp.WithHeader("Authorization", "Basic "+basicAuth(username, token))
}

Also, make sure to update the help text in the README

[mgaeta]

l := ctxzap.Extract(ctx)
err := field.Validate(Configuration, v)
if err != nil {
  return nil, err
}
jenkinsClient := client.NewClient().
  WithUser(v.GetString("username")).
  WithPassword(v.GetString("password")).
  WithToken(v.GetString("token"))

[shackra]

I mean, is that even possible without causing API errors? 😆

[shackra]

https://www.jenkins.io/doc/book/system-administration/authenticating-scripted-clients/ I think the password and token are basically interchangeable

func WithSetBasicAuthHeader(username, password string) uhttp.RequestOption {
	return uhttp.WithHeader("Authorization", "Basic "+basicAuth(username, password))
}

func WithSetTokenAuthHeader(username, token string) uhttp.RequestOption {
	return uhttp.WithHeader("Authorization", "Basic "+basicAuth(username, token))
}

Also, make sure to update the help text in the README

the client API for Jenkins has some expectations, so we cannot re-use variables to set that piece of auth information:

jenkinsClient.WithUser("random-username").WithBearerToken("magic-token")

jenkinsClient.WithUser("random-username").WithPassword("secretpassword")