Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fetch all users. By default, Okta's ListUsers doesn't return deactivated users. #24

Merged
merged 1 commit into from
Apr 5, 2024
Merged

Fetch all users. By default, Okta's ListUsers doesn't return deactivated users. #24

merged 1 commit into from
Apr 5, 2024

Conversation

ggreer
Copy link
Contributor

@ggreer ggreer commented Apr 4, 2024 •
edited
Loading

I tested this with a deactivated user. The old code doesn't sync that user. This code does.

@ggreer ggreer requested a review from degzhaus April 4, 2024 02:22
@ggreer ggreer merged commit 0c24517 into main Apr 5, 2024
2 checks passed
@ggreer ggreer deleted the ggreer/fetch-deprovisioned-users branch April 5, 2024 19:57
ggreer added a commit that referenced this pull request Apr 5, 2024
@ggreer
Fetch all users. By default, Okta's ListUsers doesn't return deactiva…
5bce965 
…ted users. (#24)
mchavez
mchavez suggested changes Apr 5, 2024
View reviewed changes
Copy link
Contributor

@mchavez mchavez left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I did not notice this PR was already closed :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mchavez mchavez mchavez requested changes

@degzhaus degzhaus Awaiting requested review from degzhaus

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ggreer @mchavez