Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make entitlement names unique #33

Merged
merged 1 commit into from
Jun 7, 2024
Merged

Make entitlement names unique #33

merged 1 commit into from
Jun 7, 2024

Conversation

ggreer
Copy link
Contributor

@ggreer ggreer commented Jun 6, 2024

We should probably pass the whole role into these functions so we can use both the type and the label, but this is better than the previous naming.

Copy link
Contributor

@mchavez mchavez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ggreer ggreer merged commit e84b183 into main Jun 7, 2024
3 checks passed
@ggreer ggreer deleted the ggreer/entitlement-names branch June 7, 2024 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants