Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom role optimizations/caching #55

Merged
merged 3 commits into from
Nov 20, 2024
Merged

Conversation

laurenleach
Copy link
Contributor

@laurenleach laurenleach commented Nov 19, 2024

  • Move custom role grants to group grants to avoid making duplicate requests for lists groups/list group assignments
  • Remove administrator logic as it does not apply to custom roles
  • Find users by list users with role assignments instead of listing all users
  • Cache user role assignments so we don't have duplicate requests for listing user role assignments per role
  • Get ResourceSet custom role grants from role resource set bindings api so we don't have to list all users and all assigned roles per user for each resource set

@laurenleach laurenleach requested a review from ggreer November 19, 2024 21:21
@laurenleach laurenleach requested a review from mchavez November 20, 2024 02:06
@ggreer ggreer merged commit 1039bac into main Nov 20, 2024
3 checks passed
@ggreer ggreer deleted the lauren/custom-role-caching branch November 20, 2024 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants