[BB-44] Unfork privx-sdk-go
#2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ggreer
reviewed
Jul 24, 2024
| github.com/SSHcom/privx-sdk-go v1.35.0 | ||
| github.com/conductorone/baton-sdk v0.2.2 | ||
| github.com/SSHcom/privx-sdk-go v1.35.1 | ||
| github.com/conductorone/baton-sdk v0.2.9 |
There was a problem hiding this comment.
The newer version of baton-sdk has a slighly different DefineConfiguration function. It accepts a whole config, not just schema fields. You'll have to tweak that before it'll build.
There was a problem hiding this comment.
Here's an example of the necessary change: https://github.com/ConductorOne/baton-ldap/pull/50/files#diff-b80bfea8c51265df2d90c7b2c3eaa095a0e1c4506adb1d9381348771f07e9de4R22
ggreer
approved these changes
Jul 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our PR was accepted, so point back to latest.
Fixes BB-44.