Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/provisioning #7

Merged
merged 3 commits into from
Feb 15, 2024
Merged

Feat/provisioning #7

merged 3 commits into from
Feb 15, 2024

Conversation

vlnevyhosteny
Copy link
Contributor

Add provisioning of group membership.

@vlnevyhosteny vlnevyhosteny requested a review from ggreer February 8, 2024 14:39
GRANT SELECT ("id", "accessLevel") ON group_folder_defaults TO baton;
GRANT SELECT ("id", "accessLevel") on group_resources TO baton;
GRANT SELECT ("id", "accessLevel") on group_resource_folder_defaults TO baton;
GRANT SELECT, INSERT, UPDATE ("id", "accessLevel") ON group_pages TO baton;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpick: maybe we want to mention that if you don't want to do provisioning, you can grant just select on these things.

Also, if we are provisioning, don't we want to grant delete too?

@@ -8,21 +8,23 @@ Check out [Baton](https://github.com/conductorone/baton) to learn more the proje
## Setup
1. While connected to the Retool database, create a new user for the connector to connect to Postgres as. Be sure to create and save the secure password for this user:
```postgresql
CREATE USER conductorone WITH PASSWORD 'secure-password';
CREATE USER baton WITH PASSWORD 'secure-password';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops. Nice catch.

@jirwin
Copy link
Contributor

jirwin commented Feb 13, 2024

I wonder if we can rely on updating the database here to add users to groups, or if there is any logic that the server does when a user is added to a group? I suppose we could compare a dump of the database before and after a member is added to a group?

@ggreer
Copy link
Contributor

ggreer commented Feb 15, 2024

I played around with this on my local retool instance and it just seems to mess with the user_groups table. 🤷‍♂️

@ggreer ggreer merged commit 4d16ce8 into main Feb 15, 2024
2 checks passed
@vlnevyhosteny vlnevyhosteny deleted the feat/provisioning branch February 19, 2024 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants