Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ref: Move configs to pkg/ #27

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

ref: Move configs to pkg/ #27

wants to merge 6 commits into from

Conversation

mgaeta
Copy link
Contributor

@mgaeta mgaeta commented Sep 10, 2024 •
edited
Loading

Description

  • update everything in go.mod to latest
  • move configs to pkg

ggreer
ggreer reviewed Sep 13, 2024
View reviewed changes
.github/workflows/ci.yaml
# run: ./baton-snowflake

- name: Run baton-snowflake
run: ./baton-snowflake
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you need env vars for BATON_ACCOUNT_IDENTIFIER, BATON_ACCOUNT_URL, BATON_PUBLIC_KEY_FINGERPRINT, and BATON_USER_IDENTIFIER. But I don't think we have a snowflake account to test against so. :(

@mgaeta mgaeta changed the title [BB-82] fix: PEM key [BB-82] ref: Move configs to pkg/ Sep 21, 2024
@mgaeta mgaeta changed the title [BB-82] ref: Move configs to pkg/ ref: Move configs to pkg/ Sep 21, 2024
@mgaeta mgaeta requested review from ggreer and a team September 21, 2024 00:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ggreer ggreer Awaiting requested review from ggreer

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mgaeta @ggreer