-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement writing down to db for LvmtStore
#17
Conversation
…e's auth_changes to satisfy KeyValueStoreBulksTrait
…6` for other purposes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 3 files at r1, all commit messages.
Reviewable status: 2 of 3 files reviewed, 1 unresolved discussion (waiting on @rongma7)
src/lvmt/storage.rs
line 100 at r1 (raw file):
// - Write to the history part is beyond the range of [`LvmtStore`]. // - The `auth_changes` in [`LvmtStore`] includes all commits, even if they are removed but not confirmed, // so consider `gc_commit` elsewhere.
Use TODO:
comments for future work.
Avoid using markdown-style comments inside function.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 2 of 3 files reviewed, 1 unresolved discussion (waiting on @ChenxingLi)
src/lvmt/storage.rs
line 100 at r1 (raw file):
Previously, ChenxingLi (Chenxing Li) wrote…
Use
TODO:
comments for future work.Avoid using markdown-style comments inside function.
Done.
…le comments inside functions
4838d67
to
070bb87
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @rongma7)
This PR implements writing to the database for
LvmtStore
within thecommit
function.amt_node_store
,key_value_store
, andslot_alloc_store
, the corresponding updates are written to their pending parts. Writing to the history part is beyond the scope ofLvmtStore
.auth_changes
is aKeyValueStoreBulks
, which typically only supports appending. Therefore, all commits, even if they are removed but not confirmed, are written toauth_changes
, so considergc_commit
elsewhere. To enable committingauth_changes
, theKey
type ofAuthChangeTable
should be changed toChangeKey
to allow theauth_changes
to satisfy theKeyValueStoreBulksTrait
.Additionally, references to
CommitID
have been updated to use the type alias, retainingH256
for other purposes.This change is