Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the commit function of LvmtStore to accept old_commit as Option<CommitID> #18

Merged
merged 1 commit into from
Jan 3, 2025
Merged

Update the commit function of LvmtStore to accept old_commit as Option<CommitID> #18

merged 1 commit into from
Jan 3, 2025

Conversation

rongma7
Copy link
Contributor

@rongma7 rongma7 commented Jan 2, 2025 •
edited by boqiu
Loading

This change is Reviewable

@rongma7 rongma7 requested a review from ChenxingLi January 2, 2025 07:37
ChenxingLi
ChenxingLi approved these changes Jan 3, 2025
View reviewed changes
Copy link
Contributor

@ChenxingLi ChenxingLi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @rongma7)

@rongma7 rongma7 merged commit 80cd1df into master Jan 3, 2025
2 checks passed
@rongma7 rongma7 deleted the first_commit branch January 3, 2025 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChenxingLi ChenxingLi ChenxingLi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rongma7 @ChenxingLi