chore: make function comments match function names #270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: dashangcun <[email protected]>
wanliqun
reviewed
Jan 10, 2025
| @@ -24,7 +24,7 @@ type filterCursor struct { | |||
| type filterChainIterator func(node *filterNode, forkPoint bool) bool | |||
|
|
|||
| type filterChain interface { | |||
| // snapshots filter cursor of the latest node | |||
| // snapshotLatestCursor filter cursor of the latest node | |||
There was a problem hiding this comment.
I think snapshotLatestCursor might be more appropriate.
What do you think? Do I need to roll back the changes here?
There was a problem hiding this comment.
I mean it should be a verb here to state the function of snapshotLatestCursor() method. Otherwise, it won't work semantically.
There was a problem hiding this comment.
How about changing it to snapshotLatestCursor returns the filter cursor of the latest node in the filter chain？
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is