Fix 'pragma solidity' parsing

[gsalzer]

remove comments and strings before searching for a line containing 'pragma solidity'

[gsalzer]

The patch tries to be minimally invasive; you may want to integrate it better. The comment citing the source can be removed (no need to give credits), it is just to inspire trust (?) that the code works since we used it for processing source codes in one of our studies.

[norhh]

For some reason, I’ve lost access to the CircleCI pipeline results over the past month. @psantos-consensys, could you look into the cause of CircleCI’s failure? Additionally, could you change the permissions to view Mythril’s CircleCI results? Since Mythril is open-source, these results should ideally be public as they were previously.

[gsalzer]

@norhh @psantos-consensys Any chance that something is going to happen in the near future? I'm fine with the pull request being rejected but this CircleCI pipeline issue occurring with every pull request now seems to be unhealthy.

[norhh]

I don't know when it will be fixed/visible. I've asked someone to look into it.

[psantos-consensys]

@norhh can you please double check if it is working as expected now?

[norhh]

@gsalzer, the test failures seem to be due to the test case related to these files: version_2.sol, version_3.sol.
The comments should be removed from these files.

[gsalzer]

@gsalzer, the test failures seem to be due to the test case related to these files: version_2.sol, version_3.sol. The comments should be removed from these files.

@norhh Please check the updated code. Now, it first searches for a regular pragma that does not occur in a comment or string, and if this fails, falls back to how Mythril searches the pragma currently (i.e., searching within comments as well).

[gsalzer]

What is the proper way to execute the tests in the tests folder?

[norhh]

Thanks a lot for the PR. Can you make these quick refactoring changes?

[gsalzer]

@norhh Refactoring done.

[norhh]

Thanks for the contribution!