tiny cleanups on BlockBlobSidecarsTrackersPoolImpl (#8975)

Consensys · Jan 9, 2025 · 3f38727 · 3f38727
1 parent 6cba4f6
commit 3f38727
Showing 1 changed file with 10 additions and 9 deletions.
diff --git a/...c/main/java/tech/pegasys/teku/statetransition/util/BlockBlobSidecarsTrackersPoolImpl.java b/...c/main/java/tech/pegasys/teku/statetransition/util/BlockBlobSidecarsTrackersPoolImpl.java
@@ -586,7 +586,6 @@ private void makeRoomForNewTracker() {
     }
   }
 
-  @SuppressWarnings("FutureReturnValueIgnored")
   private void onFirstSeen(
       final SlotAndBlockRoot slotAndBlockRoot, final Optional<RemoteOrigin> remoteOrigin) {
     final boolean isLocalBlockProduction =
@@ -598,14 +597,16 @@ private void onFirstSeen(
     final SafeFuture<Void> rpcFetchDelay =
         asyncRunner.getDelayedFuture(calculateRpcFetchDelay(slotAndBlockRoot));
 
-    asyncRunner.runAsync(
-        () ->
-            // fetch blobs from EL with no delay
-            fetchMissingBlobsFromLocalEL(slotAndBlockRoot)
-                .handleException(this::logLocalElBlobsLookupFailure)
-                .thenCompose(__ -> rpcFetchDelay)
-                .thenRun(() -> fetchMissingBlockOrBlobsFromRPC(slotAndBlockRoot))
-                .finish(this::logBlockOrBlobsRPCFailure));
+    asyncRunner
+        .runAsync(
+            () ->
+                // fetch blobs from EL with no delay
+                fetchMissingBlobsFromLocalEL(slotAndBlockRoot)
+                    .handleException(this::logLocalElBlobsLookupFailure)
+                    .thenCompose(__ -> rpcFetchDelay)
+                    .thenRun(() -> fetchMissingBlockOrBlobsFromRPC(slotAndBlockRoot))
+                    .handleException(this::logBlockOrBlobsRPCFailure))
+        .ifExceptionGetsHereRaiseABug();
   }
 
   @VisibleForTesting