Prometheus metrics library upgrade #8877
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gabriel Fukushima <[email protected]>
Signed-off-by: Gabriel Fukushima <[email protected]>
gfukushima
added
the
doc-change-required
|
Docs PR Consensys/doc.teku#624 |
Signed-off-by: Gabriel Fukushima <[email protected]>
Signed-off-by: Gabriel Fukushima <[email protected]>
Signed-off-by: Gabriel Fukushima <[email protected]>
Signed-off-by: Gabriel Fukushima <[email protected]>
Signed-off-by: Gabriel Fukushima <[email protected]>
Signed-off-by: Gabriel Fukushima <[email protected]>
Signed-off-by: Gabriel Fukushima <[email protected]>
Signed-off-by: Gabriel Fukushima <[email protected]>
Signed-off-by: Gabriel Fukushima <[email protected]>
… the same metrics system Signed-off-by: Gabriel Fukushima <[email protected]>
Signed-off-by: Gabriel Fukushima <[email protected]>
.circleci/config.yml
Outdated
| @@ -372,7 +372,7 @@ jobs: | |||
| at: ~/project | |||
| - run: | |||
| name: AcceptanceTests | |||
| no_output_timeout: 20m | |||
| no_output_timeout: 30m | |||
There was a problem hiding this comment.
Do we need this increase or was it part of your testing?
There was a problem hiding this comment.
good catch, I changed the value when I was testing and forgot to roll it back
Signed-off-by: Gabriel Fukushima <[email protected]>
…metheus-upgrade-1.x
lucassaldanha
approved these changes
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
This PR upgrades the prometheus followed by the upgrade done by besu (on main branch).
It replaces the deprecated method
MetricSystem::createLabelledGaugebyMetricSystem::createLabelledSuppliedGauge. Uses the definition of histogram created in the besu plugin and fixes tests. Since this introduces breaking changes and it depends on a release of the new metrics version of the besu plugin we might want to hold this PR until the next besu release comes out.Fixed Issue(s)
Fixes https://github.com/Consensys/teku-internal/issues/168
Documentation
doc-change-requiredlabel to this PR if updates are required.Changelog