CSSTUDIO-2880 Run refresh() atomically on the UI thread. #3215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… since the function now always runs on the UI thread.
georgweiss
approved these changes
Dec 18, 2024
shroffk
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request changes
LogEntryTableViewController.refresh()so that it runs "atomically" on the UI thread.Before this pull request, the code to select the previously selected item was run using
Platform.runLater(), which resulted in a brief period of time where no item was selected in the table view. Whenrefresh()was called in quick succession, this could cause the selected item to become not selected upon refresh.