Fix Olog HttpClient timeout and URL encoding #3238
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
URLEncoder.encode()
converts space char to+
, which does not work if the string is a path variable.Suggest to change the API for fetching attachments to use the (MongoDB) id instead of original file name, but this will require a change in the service.
All in all the native
HttpClient
is a bit of a challenge to work with... Or: the Jersey client makes a better job keeping the developer happy.Also optimizes instantiation of LogEntryTable app to avoid multiple calls to create a OlogHttpClient.
See #3236