Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Olog HttpClient timeout and URL encoding #3238

Merged
merged 1 commit into from
Jan 16, 2025
Merged

Conversation

georgweiss
Copy link
Collaborator

@georgweiss georgweiss commented Jan 16, 2025

URLEncoder.encode() converts space char to +, which does not work if the string is a path variable.
Suggest to change the API for fetching attachments to use the (MongoDB) id instead of original file name, but this will require a change in the service.

All in all the native HttpClient is a bit of a challenge to work with... Or: the Jersey client makes a better job keeping the developer happy.

Also optimizes instantiation of LogEntryTable app to avoid multiple calls to create a OlogHttpClient.

See #3236

@shroffk
Copy link
Member

shroffk commented Jan 16, 2025

I expected the app.getClient() to always return the same instance if the client had been instantiated along the lines of a singleton pattern
This is more explicit though

@shroffk shroffk merged commit 111d6ce into master Jan 16, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants