Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SER-1711: Component changes to support version management in journey #5936

Merged
merged 2 commits into from
Jan 22, 2025

Conversation

pnrgenc
Copy link
Member

@pnrgenc pnrgenc commented Jan 21, 2025

No description provided.

class="cly-vue-content-builder-header__option"
:command="option.value"
:disabled="option.disabled"
<template v-if="$slots.headerActions">

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here we can use the slot fallback, to have the same result with less HTML.

Meaning all that instead of this:

  <template v-if="$slots.headerActions">
    <slot name="headerActions"></slot>
  </template>
  <template v-else>
    <cly-status-badge
      ...
    />
    ...
  </template>

we can have this

  <slot name="headerActions">
    <cly-status-badge
      ...
    />
    ...
  </slot>

It work the same

If the slot is present, it will display whatever we add inside the slot on the parent component.
And if we do not add the slot on the parent component, it will display the elements that are inside of the slot in the content-header template.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good suggestion, thank you

@gabrieloliveirapinto gabrieloliveirapinto merged commit 5e8941a into journey+content-next Jan 22, 2025
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants