pythongh-128731: Fix ResourceWarning in robotparser.RobotFileParser.r…

…ead() (pythonGH-128733)
CraZySacX · Jan 12, 2025 · 5e65a1a · 5e65a1a
1 parent f6c61bf
commit 5e65a1a
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 0 deletions.
diff --git a/Lib/urllib/robotparser.py b/Lib/urllib/robotparser.py
@@ -65,6 +65,7 @@ def read(self):
                 self.disallow_all = True
             elif err.code >= 400 and err.code < 500:
                 self.allow_all = True
+            err.close()
         else:
             raw = f.read()
             self.parse(raw.decode("utf-8").splitlines())

diff --git a/Misc/NEWS.d/next/Library/2025-01-11-13-40-12.gh-issue-128731.qpKlai.rst b/Misc/NEWS.d/next/Library/2025-01-11-13-40-12.gh-issue-128731.qpKlai.rst
@@ -0,0 +1 @@
+Fix :exc:`ResourceWarning` in :meth:`urllib.robotparser.RobotFileParser.read`.
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1 @@
		Fix :exc:`ResourceWarning` in :meth:`urllib.robotparser.RobotFileParser.read`.