[EP-2362] Save contact info after sign up

[canac]

Changes

• Replace the onStateChange binding with dedicated onSignUp and onSignIn bindings
• After sign up, use the order service to save the donor details to the user's account. If saving fails, show the contact info form with the fields from sign up pre-populated.

I made this a PR instead of committing directly so it's easier for you to see what changed and see if I'm going in the right direction with this.

[dr-bizz]

It looks great! I have a few questions, but I don't want to block you so I will approve the PR.

[dr-bizz]

Where is signUpDonorDetails defined? Were you also meant to commit changes to the contactInfoModal.component.js

[canac]

It is set in checkDonorDetails if there was an error saving the donor details

[canac]

@dr-bizz Sorry for the force-push. I rebased on top of #1132, combined several fixup commits, and added the organization fields you added. I'll go through it myself more in tomorrow morning to see if I missed anything, but I'm pushing for you to take a look at too when you get a chance.

[dr-bizz]

Great work with this! I only had comments, nothing bad, just some of my thoughts.

I've approved this to not delay you.

[dr-bizz]

Researching flatMap I came across switchMap which could bet better for us to use as it ensures the latest request is processed.

I haven't tried this so it might not work.

Suggested change

	this.getDonorDetailsSubscription = this.orderService.getDonorDetails().flatMap((donorDetails) => {
	if (signUpDonorDetails && donorDetails['registration-state'] === 'NEW') {
	// Save the contact info from signup
	merge(donorDetails, signUpDonorDetails)
	const requests = [this.orderService.updateDonorDetails(donorDetails)]
	if (donorDetails.email) {
	requests.push(this.orderService.addEmail(donorDetails.email, donorDetails.emailFormUri))
	}
	// Send each of the requests and pass donorDetails to the next step after the requests complete
	return Observable.forkJoin(requests).map(() => donorDetails).do({
	error: () => {
	// If there was an error, save the donor details from sign up so that they will be added
	// to the contact info form. The error handler below will change the step to contact-info.
	this.signUpDonorDetails = signUpDonorDetails
	}
	})
	}
	// Pass donorDetails to the next step
	return Observable.of(donorDetails)
	}).subscribe({
	this.getDonorDetailsSubscription = this.orderService.getDonorDetails().switchMap((donorDetails) => {
	if (signUpDonorDetails && donorDetails['registration-state'] === 'NEW') {
	// Save the contact info from signup
	merge(donorDetails, signUpDonorDetails)
	const requests = [this.orderService.updateDonorDetails(donorDetails)]
	if (donorDetails.email) {
	requests.push(this.orderService.addEmail(donorDetails.email, donorDetails.emailFormUri))
	}
	// Send each of the requests and pass donorDetails to the next step after the requests complete
	return Observable.forkJoin(requests).map(() => donorDetails).catch((error) => {
	// If there was an error, save the donor details from sign up so that they will be added
	// to the contact info form. The error handler below will change the step to contact-info.
	this.signUpDonorDetails = signUpDonorDetails
	return Observable.throw(error);
	})
	}
	// Pass donorDetails to the next step
	return Observable.of(donorDetails)
	}).subscribe({

[canac]

None of the observables emit more than one item, so I don't think it matters, but I can switch it.

Why does your suggestion switch from do to catch? I was thinking that do was nice because you can pass through the same error without having to do return Observable.throw(error).

[dr-bizz]

I switched do to catch as it was easier to read, but these changes are just suggestions based on preference.

You are correct, you don't need to write Observable.throw(error) if you write do