EP-2560-QA-2 #1133
Merged
EP-2560-QA-2 #1133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wrandall22
reviewed
Jan 14, 2025
| @@ -48,17 +48,18 @@ | |||
| <h4 ng-if="$ctrl.useV3 !== 'true'" class="panel-title border-bottom-small visible" translate>{{'YOUR_INFORMATION'}}</h4> | |||
| <h4 ng-if="$ctrl.useV3 === 'true'" class="panel-title border-bottom-small visible" translate>{{'CONTACT_INFO'}}</h4> | |||
| <div class="row"> | |||
| <div class="col-sm-4"> | |||
| <div ng-class="{'col-sm-4': $ctrl.useV3 !== 'true', 'col-sm-3': $ctrl.useV3 === 'true'}"> | |||
There was a problem hiding this comment.
col-sm-6 would be 50% on desktop, which is what I think we would want on v3 (instead of col-sm-3)
wrandall22
requested changes
Jan 14, 2025
wrandall22
approved these changes
Jan 14, 2025
wjames111
force-pushed
the
EP-2560-QA-2
branch
from
5d0458b to
015c7fa
Compare
wjames111
merged commit 53cf9d1
into
EP-2517-branded-checkout-improvements
1 check passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address additional requests made in EP-2517
src/app/branded/step-1/branded-checkout-step-1.tpl.htmlmove>line upsrc/common/components/contactInfo/emailField/emailField.tpl.htmlchange file's indentation to 2 spaces.