Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement minor alignment spacing improvements #34

Merged
merged 7 commits into from
Jan 16, 2024

Conversation

dchiller
Copy link
Collaborator

@dchiller dchiller commented Jan 12, 2024

Fixes #30.

Before
image

After
image

Fixes #32.

Previously, we would infer an additional barline even in the case where all sections of volpiano and text had the same number of words. Now, we don't infer any additional barlines in this case, but simply add extra empty sections or extra sections of barlines to the end of either the text or volpiano (as we already did in the case where the text and volpiano had the same number of barlines).

image

Also, adds the dependency lock file that I had previously neglected to commit.

Copy link
Collaborator

@jacobdgm jacobdgm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. Leaving a couple of comments on purely cosmetic things, which you're totally fine to not address.

tests/alignment_test_cases.json Outdated Show resolved Hide resolved
tests/alignment_test_cases.json Outdated Show resolved Hide resolved
volpiano_display_utilities/text_volpiano_alignment.py Outdated Show resolved Hide resolved
@dchiller dchiller merged commit fbd412b into main Jan 16, 2024
1 check passed
@dchiller dchiller deleted the various-spacing-improvements branch January 16, 2024 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants