Handle issues when improper characters are passed to latin word syllabifier #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Return flag when hash respacing occurs Adjusts some typing in tests/tests.py
dchiller
force-pushed
the
i48-square-bracket-error
branch
from
058b9b8 to
a31c30e
Compare
dchiller
force-pushed
the
i48-square-bracket-error
branch
from
a31c30e to
694c735
Compare
|
I think it is charming and wonderful that CantusDB will soon have |
|
@lucasmarchd01 Got an email from Debra just now upping the priority on this. Can you review on Monday? |
lucasmarchd01
approved these changes
May 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
LatinError, and exception that inherits fromValueError, to specifically identify errors where a latin word passed to the syllabification script has improper characters. This is intended to allow applications using this utility to handle these exceptions as appropriate.cantus_text_syllabification.syllabify_textthat adds spacing to improperly space instances of hash (#)Closes #48 and closes #49 for the purposes of this repository.
Opened DDMAL/CantusDB#1423 for CantusDB to handle
LatinError