-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/load page issue #176
Open
DaidoujiChen
wants to merge
4
commits into
3.0_master
Choose a base branch
from
fix/load-page-issue
base: 3.0_master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Fix/load page issue #176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace div.gt100 selector with a more robust regex pattern to match image URLs. The new pattern matches URLs in the format: https://e-hentai.org/s/[hash]/[id]-[page]
- Remove static totalPageIndex property - Add pageSize property that updates dynamically based on actual page size - Add isEnded property to check if all items are loaded - Improve page ending detection logic
DaidoujiChen
commented
Dec 3, 2024
@@ -275,15 +275,22 @@ + (void)requestImagePagesBy:(HentaiInfo *)info atIndex:(NSInteger)index completi | |||
} | |||
else { | |||
TFHpple *xpathParser = [[TFHpple alloc] initWithHTMLData:data]; | |||
NSArray<TFHppleElement *> *pageURLs = [xpathParser searchWithXPathQuery:@"//div [@class='gt100']//a"]; | |||
// 使用更通用的 XPath 查詢,查找所有帶有 href 屬性的 a 標籤 | |||
NSArray<TFHppleElement *> *pageURLs = [xpathParser searchWithXPathQuery:@"//a[@href]"]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
直接把整個頁面 <a href
都拆下來
看起來歷史紀錄那邊也會有地方需要調整 |
… handling in requestImagePages
圖片多的時候好像會卡 main thread 要再看一下 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
嘗試修正 #175 的問題
想解決的有兩件事
我會先試試再改改中
大部分的內容是我跟 windsurf 一起改的 OwOb