Unit tests, fixes and #2 #3
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…new functionality. Right now 13 of 21 Tests failing.
… the version column.
…ot already loaded.
…imary key already exists.
Added test cases for list of ignored attributes. Fixed the lazy loading logic and added additional test cases.
|
Sorry for the delay, I will check it as soon as I can, and merge it if everything is fine! |
|
Anything happens here or is this extension dead? Because on Yii you wrote: "I don't think this extension is production ready yet" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I spent some time with your module to get more confortable with the yii unit tests and then also implemented my request in issue #2.
Im sure there are some optimisations which could be done (especially for the lazy loading on write) but i couldnt come up with a better solution for now.