test: adding tests #47
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @vvidday thanks for looking into this! I've actually been meaning to add E2E tests via Playwright but I have limited experience with that at the moment. Would love to chat about this! |
|
Closing this - deprecated by #48 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As more features are being added, it would be great if we can set up automated tests to verify the correctness of any changes and ensure new changes don't break current features.
This is a very rough draft using cypress which includes some basic tests for
Lotion::split,Lotion::merge,Block::getCaretPosandBlock::getCaretPosWithoutTags.Would greatly appreciate any input/suggestions on the approach/organization etc or if anyone would like to suggest another testing library. Wanted to check on this approach before I proceed to write more tests covering the existing features.
Example run